GEN-764 | Catch errors in debug dialog shortcut effect #2795
+1
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Current dependencies on/for this PR: This comment was auto-generated by Graphite. |
alebedev
reviewed
Jul 17, 2023
I think we are expecting some browsers to not support the APIs we are using The reason to log it to Datadog is to add the context of which type of event we are dealing with etc. But perhaps it's not such a big concern to just log as exception |
robinandeer
changed the title
robinandeer
force-pushed
the
07-17-Catch_errors_in_debug_dialog_shortcut_effect
branch
from
cd15483
to
8dd8735
Compare
robinandeer
force-pushed
the
07-17-Catch_errors_in_debug_dialog_shortcut_effect
branch
from
8dd8735
to
19c91c8
Compare
alebedev
approved these changes
Jul 17, 2023
robinandeer
deleted the
07-17-Catch_errors_in_debug_dialog_shortcut_effect
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Avoid error when checking shortcut for debug dialog
Source: https://datadoghq.eu/rum/[email protected]:d86e86d8-8d9a-4b00-a2cb-10b8d7671fa2&issueId=00c44958-2246-11ee-83d3-da7ad0900005&from_ts=1689590266557&to_ts=1689593866557&live=true
Justify why they are needed
We don't want uncaught exceptions
I decided to log an error if the code would still contain some issues
Checklist before requesting a review